feat: switch AMD CPU database to CSV#96
Merged
zleyyij merged 4 commits intoSpec-ify:mainfrom Apr 14, 2026
Merged
Conversation
Member
|
@K97i you may be able to take advantage of a standard CSV parsing crate. The reason the intel parser is bespoke is because they violate enough of the CSV spec that it's easier to just make one from scratch. I'll review now |
zleyyij
requested changes
Apr 14, 2026
Member
zleyyij
left a comment
zleyyij
left a comment
There was a problem hiding this comment.
just some minor tweaks, looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD updated their website to only output a CSV, uses some code from Intel's lexer/parser